I should also add that we would like to see more test coverage for
deoptimization before we accept such a patch. Deoptimization problems are
notoriously tricky to debug, and they are often exploitable. Inlining is
especially tricky because it involves combined stack frames - this has been
a
source of subtle bugs in the past.
Ideally, deoptimization tests should try to deoptimize for every simulate
that
your change has affected or introduced (both for the inlining and
non-inlining
case).
https://codereview.chromium.org/350913002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
