Reviewers: jarin,
Message:
FYI
Description:
Fix clusterfuzz check in auto-roll.
Minor fixes: Strip new lines from api key. Missing import. Use string query
parameters.
BUG=
[email protected]
Please review this at https://codereview.chromium.org/353813002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -2 lines):
M tools/push-to-trunk/auto_roll.py
M tools/push-to-trunk/common_includes.py
Index: tools/push-to-trunk/auto_roll.py
diff --git a/tools/push-to-trunk/auto_roll.py
b/tools/push-to-trunk/auto_roll.py
index
e6cbed525f43d0df3e215ab4092c834f42927772..6e6c7fe2abcc091802a318d9d189cb09be87d20e
100755
--- a/tools/push-to-trunk/auto_roll.py
+++ b/tools/push-to-trunk/auto_roll.py
@@ -80,7 +80,7 @@ class CheckClusterFuzz(Step):
result = self._side_effect_handler.ReadClusterFuzzAPI(
api_key, job_type="linux_asan_d8_dbg", reproducible="True",
open="True", bug_information="",
- revision_greater_or_equal=self["last_push"])
+ revision_greater_or_equal=str(self["last_push"]))
if result:
print "Stop due to pending ClusterFuzz issues."
return True
Index: tools/push-to-trunk/common_includes.py
diff --git a/tools/push-to-trunk/common_includes.py
b/tools/push-to-trunk/common_includes.py
index
86d33ca0c0508c8711612a73d5499f2987b0f439..4dfb6d7d279449d7dfcc5c2f1e6dc66562899004
100644
--- a/tools/push-to-trunk/common_includes.py
+++ b/tools/push-to-trunk/common_includes.py
@@ -37,6 +37,7 @@ import subprocess
import sys
import textwrap
import time
+import urllib
import urllib2
from git_recipes import GitRecipesMixin
@@ -209,7 +210,7 @@ class SideEffectHandler(object): # pragma: no cover
url_fh.close()
def ReadClusterFuzzAPI(self, api_key, **params):
- params["api_key"] = api_key
+ params["api_key"] = api_key.strip()
params = urllib.urlencode(params)
headers = {"Content-type": "application/x-www-form-urlencoded"}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
