On 2014/06/25 10:45:59, wingo wrote:
On 2014/06/25 10:43:07, wingo wrote:
> On 2014/06/25 10:24:58, marja wrote:
> > On 2014/06/25 10:13:17, wingo wrote:
> > > Committed patchset #1 manually as r22005 (presubmit successful).
> >
> > ... you could've removed the comment I pointed out tho...
>
> I'm sorry, I thought I did. Clearly juggling too many patches today;
will
take
> a look.
Yes, I believe I got this fix in. Should I re-upload for these sorts of
l.g.t.m
with nits feedback?
I'd say you should always upload the patch set which you commit. Otherwise
it
gets very confusing!
Also, the commit message says "committed patch set #1 manually", so I
thought
you committed patch set 1... which is apparently not the case?
https://codereview.chromium.org/350353002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
