Reviewers: Yang,
Message:
Committed patchset #1 manually as r22008 (presubmit successful).
Description:
Fix --trace-ic position information for LoadICs and StoreICs in optimized
code
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=22008
Please review this at https://codereview.chromium.org/352663002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -0 lines):
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
339e0d3a8aba3297551cefdabb6e799b63201e1a..d4ea58084f4037c4dd2e17f0c14300a2b0f89bdf
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -6512,6 +6512,7 @@ void
HOptimizedGraphBuilder::VisitAssignment(Assignment* expr) {
ASSERT(!HasStackOverflow());
ASSERT(current_block() != NULL);
ASSERT(current_block()->HasPredecessor());
+ if (!FLAG_hydrogen_track_positions) SetSourcePosition(expr->position());
VariableProxy* proxy = expr->target()->AsVariableProxy();
Property* prop = expr->target()->AsProperty();
ASSERT(proxy == NULL || prop == NULL);
@@ -7213,6 +7214,8 @@ void HOptimizedGraphBuilder::VisitProperty(Property*
expr) {
ASSERT(current_block() != NULL);
ASSERT(current_block()->HasPredecessor());
+ if (!FLAG_hydrogen_track_positions) SetSourcePosition(expr->position());
+
if (TryArgumentsAccess(expr)) return;
CHECK_ALIVE(VisitForValue(expr->obj()));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
