Reviewers: Yang,
Description:
Better fix for --trace-ic source positions: Use
HOptimizedGraphBuilderWithPositions
This reverts the changes made in r22008.
Please review this at https://codereview.chromium.org/355823003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -4 lines):
M src/compiler.cc
M src/hydrogen.cc
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index
d9fb4a9b0d0335045a42477c6378879061f555c4..f471224b42c5430f7f2c551efe569f0e10609990
100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -394,7 +394,7 @@ OptimizedCompileJob::Status
OptimizedCompileJob::CreateGraph() {
// Type-check the function.
AstTyper::Run(info());
- graph_builder_ = FLAG_hydrogen_track_positions
+ graph_builder_ = (FLAG_hydrogen_track_positions || FLAG_trace_ic)
? new(info()->zone()) HOptimizedGraphBuilderWithPositions(info())
: new(info()->zone()) HOptimizedGraphBuilder(info());
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
d4ea58084f4037c4dd2e17f0c14300a2b0f89bdf..339e0d3a8aba3297551cefdabb6e799b63201e1a
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -6512,7 +6512,6 @@ void
HOptimizedGraphBuilder::VisitAssignment(Assignment* expr) {
ASSERT(!HasStackOverflow());
ASSERT(current_block() != NULL);
ASSERT(current_block()->HasPredecessor());
- if (!FLAG_hydrogen_track_positions) SetSourcePosition(expr->position());
VariableProxy* proxy = expr->target()->AsVariableProxy();
Property* prop = expr->target()->AsProperty();
ASSERT(proxy == NULL || prop == NULL);
@@ -7214,8 +7213,6 @@ void HOptimizedGraphBuilder::VisitProperty(Property*
expr) {
ASSERT(current_block() != NULL);
ASSERT(current_block()->HasPredecessor());
- if (!FLAG_hydrogen_track_positions) SetSourcePosition(expr->position());
-
if (TryArgumentsAccess(expr)) return;
CHECK_ALIVE(VisitForValue(expr->obj()));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
