Revision: 22012
Author: [email protected]
Date: Wed Jun 25 12:37:06 2014 UTC
Log: Better fix for --trace-ic source positions: Use
HOptimizedGraphBuilderWithPositions
This reverts the changes made in r22008.
[email protected]
Review URL: https://codereview.chromium.org/355823003
http://code.google.com/p/v8/source/detail?r=22012
Modified:
/branches/bleeding_edge/src/compiler.cc
/branches/bleeding_edge/src/hydrogen.cc
=======================================
--- /branches/bleeding_edge/src/compiler.cc Tue Jun 24 14:03:24 2014 UTC
+++ /branches/bleeding_edge/src/compiler.cc Wed Jun 25 12:37:06 2014 UTC
@@ -394,7 +394,7 @@
// Type-check the function.
AstTyper::Run(info());
- graph_builder_ = FLAG_hydrogen_track_positions
+ graph_builder_ = (FLAG_hydrogen_track_positions || FLAG_trace_ic)
? new(info()->zone()) HOptimizedGraphBuilderWithPositions(info())
: new(info()->zone()) HOptimizedGraphBuilder(info());
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Wed Jun 25 12:12:21 2014 UTC
+++ /branches/bleeding_edge/src/hydrogen.cc Wed Jun 25 12:37:06 2014 UTC
@@ -6512,7 +6512,6 @@
ASSERT(!HasStackOverflow());
ASSERT(current_block() != NULL);
ASSERT(current_block()->HasPredecessor());
- if (!FLAG_hydrogen_track_positions) SetSourcePosition(expr->position());
VariableProxy* proxy = expr->target()->AsVariableProxy();
Property* prop = expr->target()->AsProperty();
ASSERT(proxy == NULL || prop == NULL);
@@ -7214,8 +7213,6 @@
ASSERT(current_block() != NULL);
ASSERT(current_block()->HasPredecessor());
- if (!FLAG_hydrogen_track_positions) SetSourcePosition(expr->position());
-
if (TryArgumentsAccess(expr)) return;
CHECK_ALIVE(VisitForValue(expr->obj()));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
