On 2014/06/11 11:52:14, yurys wrote:
https://codereview.chromium.org/264333007/diff/150001/src/debug.h
File src/debug.h (left):
https://codereview.chromium.org/264333007/diff/150001/src/debug.h#oldcode368
src/debug.h:368: NO_AFTER_COMPILE_FLAGS,
It might make sense to do this clean-up in a separate change.
Extracted to https://codereview.chromium.org/353823004/
On 2014/06/25 07:26:23, Yang wrote:
https://codereview.chromium.org/264333007/diff/150001/include/v8-debug.h
File include/v8-debug.h (right):
https://codereview.chromium.org/264333007/diff/150001/include/v8-debug.h#newcode24
include/v8-debug.h:24: CompileError = 8
We have the same table (without BrekaForCommand) in debug-debugger.js. I
do
think this new one needs to be there as well so that the debug event
listener
can distinguish the events. Also, please make CompileError=7 and
BreakForCommand=8 (the latter is not exposed to the debug event listener).
Done.
If possible, a test case for a JS debug event listener would be great.
Modified existing test: debug-compile-event.js.
https://codereview.chromium.org/264333007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
