LGTM.
There are many more places where we should use the new register
definitions, but
that can wait. (arm64 ic/stub generation quite consistently uses symbolic
names
already; other platforms should follow suit.)
https://codereview.chromium.org/356713003/diff/100001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/356713003/diff/100001/src/arm/lithium-codegen-arm.cc#newcode3073
src/arm/lithium-codegen-arm.cc:3073:
ASSERT(ToRegister(instr->object()).is(r0));
don't need this any more
https://codereview.chromium.org/356713003/diff/100001/src/ia32/ic-ia32.cc
File src/ia32/ic-ia32.cc (right):
https://codereview.chromium.org/356713003/diff/100001/src/ia32/ic-ia32.cc#newcode575
src/ia32/ic-ia32.cc:575: Register receiver = edx;
awww... come on!
https://codereview.chromium.org/356713003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
