On Tue, Mar 3, 2009 at 11:40 PM, Alex Iskander <[email protected]> wrote:
> #define WHPRINTF_RETURN if( zExtra ) free(zExtra); return ResultString
> To:
> #define WHPRINTF_RETURN if( zExtra ) free(zExtra); return
> sentry.Close(ResultString);

Wow, thanks for taking a look so quickly! (And you got it from the
source repo, even!)

Aha! i never did remember to close my scopes.

> But if I recall, you don't actually need handle scopes inside function
> callbacks (some people mentioned that v8 already had them in these
> situations, which makes sense), so the point may be moot. Other than that,

That was my assumption. i've always gotten segfaults with HandleScope,
but maybe because i wasn't calling Close().

> you are probably handling memory alright; you aren't using persistent
> handles, and the handle scope is taken care of, so v8-wise, you shouldn't be
> leaking.

:-D

> If you don't know what HandleScope::Close() does, I think I cover it
> in http://create.tpsitulsa.com/wiki/V8/Handles#Escaping_Scope , under
> "Escaping Scope."
> Hope that helps,

Very much, indeed. Thank you!

-- 
----- stephan beal
http://wanderinghorse.net/home/stephan/

--~--~---------~--~----~------------~-------~--~----~
v8-users mailing list
[email protected]
http://groups.google.com/group/v8-users
-~----------~----~----~----~------~----~------~--~---

Reply via email to