Hi, On Aug 17, 11:54 am, pikpik <[email protected]> wrote: > On Aug 17, 3:52 am, Søren Gjesse <[email protected]> wrote:
> > The call to the static function is mussing the class name. Please try out > > the change in http://codereview.chromium.org/3125014. > > I will try this next. Ok, I've tried the change, but the result is quite similar: /usr/gnu/bin/g++ -o obj/release/jsregexp.o -c -Wall -Werror -W -Wno- unused-parameter -Wnon-virtual-dtor -pedantic -m32 -O3 -fomit-frame- pointer -ansi -Wno-char-subscripts -fno-strict-aliasing -fno-tree-vrp - fno-rtti -fno-exceptions -Wall -Werror -W -Wno-unused-parameter -Wnon- virtual-dtor -pedantic -m32 -O3 -fomit-frame-pointer -ansi -Wno-char- subscripts -fno-strict-aliasing -fno-tree-vrp -DV8_TARGET_ARCH_IA32 - DENABLE_VMSTATE_TRACKING -DENABLE_LOGGING_AND_PROFILING - DENABLE_DEBUGGER_SUPPORT -Isrc src/jsregexp.cc src/jsregexp.cc:383: error: prototype for 'v8::internal::RegExpImpl::IrregexpResult v8::internal::RegExpImpl::IrregexpExecOnce(v8::internal::Handle<v8::internal::JSRegExp>, v8::internal::Handle<v8::internal::String>, int, v8::internal::Vector<int>)' does not match any in class 'v8::internal::RegExpImpl' src/jsregexp.h:114: error: candidate is: static v8::internal::RegExpImpl::IrregexpResult v8::internal::RegExpImpl::IrregexpExecOnce(v8::internal::Handle<v8::internal::JSRegExp>, v8::internal::Handle<v8::internal::String>, int, v8::internal::Vector<long int>) src/jsregexp.cc: In static member function 'static v8::internal::Handle<v8::internal::Object> v8::internal::RegExpImpl::IrregexpExec(v8::internal::Handle<v8::internal::JSRegExp>, v8::internal::Handle<v8::internal::String>, int, v8::internal::Handle<v8::internal::JSArray>)': src/jsregexp.cc:483: error: no matching function for call to 'v8::internal::RegExpImpl::IrregexpExecOnce(v8::internal::Handle<v8::internal::JSRegExp>&, v8::internal::Handle<v8::internal::String>&, int&, v8::internal::Vector<int>)' src/jsregexp.h:114: note: candidates are: static v8::internal::RegExpImpl::IrregexpResult v8::internal::RegExpImpl::IrregexpExecOnce(v8::internal::Handle<v8::internal::JSRegExp>, v8::internal::Handle<v8::internal::String>, int, v8::internal::Vector<long int>) scons: *** [obj/release/jsregexp.o] Error 1 scons: building terminated because of errors. I've noticed that the largest difference between the call and the candidate is that the last parameters are "Vector<int>" and "Vector<long int>," respectively. So, I've changed the call (at "src/ jsregexp.cc:483") to use the last parameter as "Vector<long int>," and am currently testing it. I hope this is a good idea, pikpik -- v8-users mailing list [email protected] http://groups.google.com/group/v8-users
