2011/1/4 Søren Gjesse <[email protected]> > I see - it will be OK to add this to v8.gyp.
Great - submitted http://codereview.chromium.org/6092006/ for review. > I wonder why all the targets are required in the Gentoo gyp file. For a > system V8 then only the v8 target should be required, as that is the only > think that you can link with. Whether to use snapshots or not is determined > by the system library and not by the consumer. Oh, right. I've removed those from my CL. > By the way why are values 0/1 used instead of false/true? I would prefer > real booleans as is used by the variable v8_use_snapshot, but of cause > consistency also matters the other way. > I've submitted with 0/1, for consistency with other use_system_ gyp options. Please note that in the current version of v8.gyp there seem to be two bool variables, one using 0/1 and one using true/false. Either way use_system_v8 would be inconsistent, so I opted for "global" consistency instead. Of course we can discuss this more in the review issue, I'm fine with either solution. -- v8-users mailing list [email protected] http://groups.google.com/group/v8-users
