On Thu, Oct 6, 2011 at 04:40, Paweł Hajdan, Jr. <[email protected]>wrote:
> On Wed, Oct 5, 2011 at 15:07, Paul Robinson <[email protected]> wrote: > >> When this happened to me, it was because cpplint.py (in depot_tools) had a >> first line that said >> #!/usr/bin/python2.4 >> but of course I have a more recent version of python. Removing the "2.4" >> made the problem go away. >> > > Doesn't seem to be the case here. I think cpplint.py is not part of my > checkout (checked with "find"). > Ah, yes. I wasn't aware of it previously, but the tools/presubmit.py script depends on cpplint.py being either in the tools/ directory or in $PATH (e.g. as part of depot_tools). I've added a try..except to gracefully handle the case when it isn't found. Another issue is that cpplint.py as found in depot_tools does indeed have a "#!/usr/bin/python2.4" line, so if you don't have that particular symlink, YMMV. This is outside the V8 project, though. I've also added an optional presubmit=no parameter (or, equivalently, TESTFLAGS=<whatever>) to the Makefile, so you can skip running presubmit tests entirely if you wish. Until this change has landed, a hackish workaround is to piggyback on the TESTJOBS parameter: make -j3 ia32.release.check TESTJOBS="-j2 --no-presubmit" As for test timeouts, they are obviously hardware performance dependent. Note the Makefile's TESTJOBS parameter, which defaults to -j16. On a dual-core machine, you'll want to call: make -j3 ia32.release.check TESTJOBS=-j2 or your tests will timeout because they're fighting for CPU time. For reference: http://codereview.chromium.org/8159015/ > -- > v8-users mailing list > [email protected] > http://groups.google.com/group/v8-users > -- v8-users mailing list [email protected] http://groups.google.com/group/v8-users
