Fixed in bleeding_edge r11838 and trunk r11844.
On Sat, Jun 16, 2012 at 5:17 PM, mschwartz <[email protected]> wrote: > This is definitely an issue. > > MaybeObject* JSObject::OptimizeAsPrototype() { > if (IsGlobalObject()) return this; > > // Make sure prototypes are fast objects and their maps have the bit set > // so they remain fast. > // Map* proto_map = map(); > if (!HasFastProperties()) { > MaybeObject* new_proto = TransformToFastProperties(0); > if (new_proto->IsFailure()) return new_proto; > ASSERT(new_proto == this); > // proto_map = map(); > } > return this; > } > > Note the two lines I had to comment out to make this compile. > > > > On Friday, June 15, 2012 9:34:57 AM UTC-7, mschwartz wrote: >> >> make[3]: Entering directory `/home/mschwartz/src/SilkJS/** >> src/v8-read-only/out' >> LINK(target) /home/mschwartz/src/SilkJS/**src/v8-read-only/out/x64.** >> release/preparser >> CXX(target) /home/mschwartz/src/SilkJS/**src/v8-read-only/out/x64.** >> release/obj.target/v8_base/**src/objects.o >> ../src/objects.cc: In member function ‘v8::internal::MaybeObject* >> v8::internal::JSObject::**OptimizeAsPrototype()’: >> ../src/objects.cc:7517:8: error: variable ‘proto_map’ set but not used >> [-Werror=unused-but-set-**variable] >> cc1plus: all warnings being treated as errors >> make[3]: *** [/home/mschwartz/src/SilkJS/**src/v8-read-only/out/x64.** >> release/obj.target/v8_base/**src/objects.o] Error 1 >> make[3]: Leaving directory `/home/mschwartz/src/SilkJS/** >> src/v8-read-only/out' >> make[2]: *** [x64.release] Error 2 >> make[2]: Leaving directory `/home/mschwartz/src/SilkJS/** >> src/v8-read-only' >> make[1]: *** [v8-read-only/out/x64.release/**obj.target/tools/gyp/libv8_* >> *base.a] Error 2 >> make[1]: Leaving directory `/home/mschwartz/src/SilkJS/**src' >> make: *** [all] Error 2 >> >> -- v8-users mailing list [email protected] http://groups.google.com/group/v8-users
