Some internal properties are implemented using property callbacks, for
example string.length. Since strings are not Objects, but Values, the extra
checks that commit introduced failed in that particular case. The holder is
String.prototype though. This does not apply to FunctionCallbackInfo, so we
left that as is. I hope this helps.
Yang
On Tuesday, May 13, 2014 12:34:21 PM UTC+2, Ben Noordhuis wrote:
>
> Hi,
>
> Commit r21022 ("Tighten OpenHandle's extra checks.")[1] changes the
> return type of PropertyCallbackInfo<T>::This() from Local<Object> to
> Local<Value> for reasons that are not clear to me.
> FunctionCallbackInfo<T>::This() still returns a Local<Object>, as do
> the Holder() methods of both classes.
>
> Can someone from the V8 team comment on the change? It's breaking
> some hitherto working code and while it's seemingly trivial to update
> to the new API, I would like to understand the reasoning behind the
> change before I do so.
>
> Thanks,
>
> Ben
>
> [1] https://codereview.chromium.org/240113010/
>
--
--
v8-users mailing list
[email protected]
http://groups.google.com/group/v8-users
---
You received this message because you are subscribed to the Google Groups
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
