So it sounds like we can move forward with this change without too much hassle for embedders anyway. Awesome.
On Sat, Dec 12, 2015, 07:44 Alex Kodat <[email protected]> wrote: > First, I'm really impressed with this group's responsiveness. Awesome! > > Second, I apologize if I gave folks extra work to do -- my intent was > simply to give a heads up to other embedders. As it turns out, I was able > to get rid of my two Callee uses. Jochen's suggestion caused a neuron to > fire and I realized that I could just use the FunctionTemplate constructor > data parameter to pass whatever I needed to args.Data(). In the cases where > I just needed the function name, I simply set data to reference a String > with the name. In the cases where I needed a name and constructor, I simply > set data to reference an object with property "name" and property > "constructor", the latter set after the function was instantiated (so the > FunctionTemplate had an indirect forward reference to its Function). > > Dunno if similar techniques could be used to compensate for the loss of > Callee out in the wild but it took all of two hours to get rid of mine, > anyway. And now that *I* don't need Callee any more, I can argue for > reducing the weight of FunctionCallbackInfo. ;-) > > > On Friday, December 11, 2015 at 5:21:42 AM UTC-8, Enrico Pertoso wrote: >> >> Update: we reverted the cl for now, so Callee() is back. >> >> On Friday, December 11, 2015 at 11:55:07 AM UTC+1, Ben Noordhuis wrote: >>> >>> On Fri, Dec 11, 2015 at 11:23 AM, Jochen Eisinger <[email protected]> >>> wrote: >>> > I just saw that node.js/nan also uses Callee() so we should try to >>> figure out a way to keep it >>> >>> FWIW, node.js core doesn't use .Callee() and I don't think there are >>> many (if any) add-ons that use the nan wrapper. >>> >> -- -- v8-users mailing list [email protected] http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
