I see, thank you.
On Mon, Feb 29, 2016 at 3:45 AM, Jochen Eisinger <[email protected]> wrote: > Please don't use Isolate::GetCurrent() - it's deprecated. > > If you need to know whether the Isolate was disposed or not, why not > maintain a boolean flag on the worker thread that keeps track of the > isolate's state? > > On Fri, Feb 26, 2016 at 7:16 PM Yutaka Hirano <[email protected]> > wrote: > >> Hi, >> >> I'm writing a unit tests in blink and I want to check if an isolate is >> disposed in a worker thread. In v8.h, v8::Isolate::GetCurrent() header >> comment says >> >> /** >> * Returns the entered isolate for the current thread or NULL in >> * case there is no current isolate. >> * >> * This method must not be invoked before V8::Initialize() was invoked. >> */ >> >> , but in the implementation in src/isolate.h, returning null is not >> allowed. >> >> Which is correct? Can I remove the DCHECK? >> >> Thanks, >> >> -- >> -- >> v8-users mailing list >> [email protected] >> http://groups.google.com/group/v8-users >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > v8-users mailing list > [email protected] > http://groups.google.com/group/v8-users > --- > You received this message because you are subscribed to the Google Groups > "v8-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-users mailing list [email protected] http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
