I actually think this is a bug in our work flow. I 
filed http://crbug.com/648583

You can also pass -p to v8gen.py to let it perform an additional gn run 
over the extra cmd line parameters automatically.

On Tuesday, September 20, 2016 at 9:16:56 AM UTC+2, Jochen Eisinger wrote:
>
> v8gen creates the input for gn. gn creates the input for ninja. ninja 
> builds the binaries.
>
> You can use gn gen out.gn/x64.release instead of gn args if you don't 
> intend to change the args anyways.
>
> best
> -jochen
>
> On Mon, Sep 19, 2016 at 9:19 PM Andre Cunha <andre.l...@gmail.com 
> <javascript:>> wrote:
>
>> PS: the same behavior applies to i18n support in debug mode. When I run 
>> v8gen.py with "v8_enable_i18n_support=false", the build process still 
>> generates libraries that depend on ICU. I need to run gn and ninja again to 
>> get rid of the dependency.
>>
>> On Monday, September 19, 2016 at 3:55:08 PM UTC-3, Andre Cunha wrote:
>>>
>>> Hello,
>>>
>>> I'm building v8 5.4 using the following commands (Ubuntu 14.04, x64):
>>>
>>> $ fetch v8
>>> $ cd v8
>>> $ git checkout remotes/branch-heads/5.4
>>> $ gclient sync
>>> $ tools/dev/v8gen.py x64.release -- is_component_build=true 
>>> v8_enable_i18n_support=false
>>> $ ninja -C out.gn/x64.release
>>>
>>> However, when I do this, libv8.so is *not* generated in 
>>> out.gn/x64.release. In order for it to be generated, I need to do:
>>>
>>> $ gn args out.gn/x64.release
>>> # Close vi (no need to save).
>>> $ ninja -C out.gn/x64.release
>>>
>>> Then, 851 files are (re)compiled and libv8.so is generated.
>>>
>>> Why do I need to re-run gn for the options to take effect? Am I missing 
>>> some step in the building process?
>>>
>>> Thank you!
>>> Andre
>>>
>> -- 
>> -- 
>> v8-users mailing list
>> v8-u...@googlegroups.com <javascript:>
>> http://groups.google.com/group/v8-users
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "v8-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to v8-users+u...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to