Hi, Thanks for confirming and fixing. Cheers from cloudy cologne, Wilfried Goesgens
On Wednesday, February 20, 2019 at 11:55:11 AM UTC+1, Ulan Degenbaev wrote: > > Here is the patch: > https://chromium-review.googlesource.com/c/v8/v8/+/1478695 > > On Wed, Feb 20, 2019 at 11:21 AM Ulan Degenbaev <ul...@google.com > <javascript:>> wrote: > >> Hi Wilfried, >> >> Thanks for the report. The "do-nothing" case should occur limited number >> of times and then switch to "done" [1]. >> There seems to be a bug that can lead to unbounded "do-nothing". >> >> I think the "do-nothing" case is no longer useful, so we can simply merge >> it with the "done" case. I'll upload a patch for that. >> >> Cheers, >> Ulan. >> >> [1]: >> https://cs.chromium.org/chromium/src/v8/src/heap/gc-idle-time-handler.h?rcl=fee9be7abb565fc2f2ae7c20e7597bece4fc7144&l=123 >> >> On Tue, Feb 19, 2019 at 6:02 PM Wilfried Gösgens <doth...@gmail.com >> <javascript:>> wrote: >> >>> Hi, >>> I saw that *IdleNotificationDeadline()* in term invokes >>> *Heap::PerformIdleTimeAction() (heap.cc), * >>> And in case of `action.type == DO_NOTHING` it will return false. >>> So ArangoDB kept on invoking IdleNotificationDeadline() without any >>> effect. >>> >>> Did we set up the preconditions wrong (so type wouldn't be DO_NOTHING >>> here?) or should there be in fact a >>> >>> * result = true;* >>> >>> Cheers, >>> Wilfried Goesgens >>> >>> -- >>> -- >>> v8-users mailing list >>> v8-u...@googlegroups.com <javascript:> >>> http://groups.google.com/group/v8-users >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-users" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to v8-users+u...@googlegroups.com <javascript:>. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
