Rodrigo, what's your project? I tried and failed to fix this build, I'd happily throw a few hundred dollars in gratitude at anyone able to get it working stably. I wonder if there might be other users out there in the same boat. Ben
On Fri, 17 Jul 2020 at 03:40, Rodrigo Hernandez < kwizatz.aeongames....@gmail.com> wrote: > > Ok, found the problem, beside some missing V8_PRIVATE_EXPORTs, > v8_enable_verify_heap is broken on component builds. > > v8_enable_verify_heap is enabled by is_debug, and it causes > the VERIFY_HEAP define to be added to the compilation flags, > gen\torque-generated\class-verifiers-tq.cc (Not sure which .tq file > generates this one) has a file wide guard for this VERIFY_HEAP define, so > even if compiled, if not set, produces no code. > > The problem then is that functions inside class-verifiers-tq.cc reference > functions in v8_initializers, which is a dependency ONLY exposed in > v8_for_testing (and v8_init, but that's not a lib). > > Since I doubt verify heap is intended for test only targets, I guess > functions in class-verifiers-tq.cc should not be calling anything in > v8_initializers. > > Either way adding v8_enable_verify_heap=false (even if you have > is_debug=true) to the args removes those cryptic undefined symbol errors. > > > On Tuesday, July 14, 2020 at 11:50:03 AM UTC-6, Rodrigo Hernandez wrote: >> >> >> Got to the same point with branch head 8.1, did some dependency moves >> like adding v8_initializers as a v8 dependency as well as wasm_api_test as >> well as adding some missing V8_EXPORT macros until I got to the point where >> NodeCache<int64_t> was undefined, >> moved more deps and got duplicated symbols. >> >> Somehow I don't think adding the deps is what's missing, the symbols >> should be there somewhere or the clang build would fail as well, but it >> doesn't, I think it has to do with either the assembly generation or >> something that was left undone when wee8 was added. >> >> I have patches for building with MSYS + MinGW64, and none of these issues >> showed up when writing those, so there must be something GCC/CLANG is doing >> that MSVC is not doing yet. >> >> I need to drop this project until the weekend, I'll come back try to >> figure out what am I missing then, in the meantime, any hints of what could >> be going on are welcome. >> >> Thanks again. >> > -- > -- > v8-users mailing list > v8-users@googlegroups.com > http://groups.google.com/group/v8-users > --- > You received this message because you are subscribed to the Google Groups > "v8-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-users+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-users/20e44a86-a777-4291-a663-ed8c52fd7d35o%40googlegroups.com > <https://groups.google.com/d/msgid/v8-users/20e44a86-a777-4291-a663-ed8c52fd7d35o%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/CABexdQ6%2B9ZAFKXnh6MBjUK%2BkzutNOpfJ9-mhjC3%2BmK2iiYf9fw%40mail.gmail.com.
