Somewhat belated: https://chromium-review.googlesource.com/c/v8/v8/+/5878258
I've picked you as a reviewer, Jakob. Hope you don't mind. On Fri, Aug 16, 2024 at 11:37 AM Jakob Kummerow <jkumme...@chromium.org> wrote: > > Thanks for reporting back! > If you're so inclined, feel free to submit a patch that detects this problem > and explicitly warns about it. Grep for "build configuration mismatch" > (you'll find hits in api.cc) to find existing examples where we do this. > > > On Wed, Aug 14, 2024 at 11:04 PM Ben Noordhuis <i...@bnoordhuis.nl> wrote: >> >> On Fri, Aug 9, 2024 at 9:02 AM Sam Saffron <sam.saff...@gmail.com> wrote: >> > 4. For some reason if I build with `is_debug` as soon as I kick off an >> > isolate I get warned about stack smashing, is this normal? Do "is_debug" >> > builds work for people? >> >> For posterity, this turned out to be a mismatch between the V8 build >> and the consumer of V8's API headers. Both need to be compiled with >> V8_ENABLE_CHECKS defined; it affects object layouts. >> >> (Nitty gritty: v8::HandleScope has an extra field in debug mode that >> its constructor initializes. The consumer didn't allocate enough stack >> space.) >> >> -- > > -- > -- > v8-users mailing list > v8-users@googlegroups.com > http://groups.google.com/group/v8-users > --- > You received this message because you are subscribed to the Google Groups > "v8-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-users+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-users/CAKSzg3TVTUgXsdtm6n6PU0_puUJ%3D5QKkVq1OTV4ZvSF_cKSEzA%40mail.gmail.com. -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/CAHQurc9-Hw5WesqRUxGxcokCULsgpbm6mqWiAXyR%2BbKN6_jYcA%40mail.gmail.com.
