Steven, Even if Travis fails, you can keep the PR open. We will review it even if it fails :)
Best, Seth > On Nov 1, 2014, at 5:55 PM, Steven Edwards <[email protected]> wrote: > > Hey Seth, > > Thank you for challenging me to take another look. > > I was up-to-date and my code additions, minor though they are, were correct. > A unit test that checked all supported attributes tripped me up--adding the > new attribute to the unit test allowed Travis to give me a passing grade. > > Now to submit a new pull request. > > Thanks again, > > Steven > > On Saturday, November 1, 2014 1:17:27 PM UTC-4, Seth Vargo wrote: > Hi Steven, > > The last successful build was > https://travis-ci.org/mitchellh/vagrant/builds/39640098 > <https://travis-ci.org/mitchellh/vagrant/builds/39640098>. Please make sure > you are forking the latest version from master and have rebased. > > Best, > Seth > >> On Nov 1, 2014, at 11:32 AM, Steven Edwards <[email protected] >> <javascript:>> wrote: >> >> Should pull requests be based on v1.6.5, master, or the last successful >> build <https://travis-ci.org/mitchellh/vagrant/builds/39640098>? >> >> I submitted this pull request >> <https://github.com/mitchellh/vagrant/pull/4763> this morning (see diff >> <https://github.com/stephenwithav/vagrant/compare/ansible-force-read>) and >> Travis-CI reported build errors >> <https://travis-ci.org/mitchellh/vagrant/builds/39676899>, but the build >> before mine failed, too, so I don't know where/when the breakage occurred >> and how that impacts what I submit to. >> >> I have vagrant 1.6.5 installed with the same changes added and it works >> perfectly, but I would love to see the feature included upstream. >> >> Any and all help on the best way to submit a pull request will be >> appreciated. >> >> Best, >> >> Steven >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Vagrant" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout >> <https://groups.google.com/d/optout>. > > > -- > You received this message because you are subscribed to the Google Groups > "Vagrant" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>.
smime.p7s
Description: S/MIME cryptographic signature
