On Thu, 4 Oct 2007, Dirk Mueller wrote:

> On Wednesday, 3. October 2007, Julian Seward wrote:
>
>> Addr/Word/UWord args with %p formats, either by casting the arg to void*
>> or changing the format to 0x%lx.
>
> I'm currently unable to decide which route to take. We can represent Addr in
> two ways:
>
>  VG_(printf)("%#lx", ..)
>
> or
>  VG_(printf)("%p", (void*)..)
>
> I would prefer the first, given that it is shorter. Any comments? I'll make
> sure that I change it consistently (in a new branch, like requested).

I prefer the second, because I find it easier to remember.  Also, AFAICT 
Valgrind's 'printf' doesn't handle '#'.

Nick

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Valgrind-developers mailing list
Valgrind-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/valgrind-developers

Reply via email to