Author: njn Date: 2007-10-12 06:12:48 +0100 (Fri, 12 Oct 2007) New Revision: 6988
Log: minor tweaks Modified: branches/MASSIF2/massif/ms_main.c Modified: branches/MASSIF2/massif/ms_main.c =================================================================== --- branches/MASSIF2/massif/ms_main.c 2007-10-12 03:37:58 UTC (rev 6987) +++ branches/MASSIF2/massif/ms_main.c 2007-10-12 05:12:48 UTC (rev 6988) @@ -653,10 +653,9 @@ n_dupd_xpts_freed++; } -// Sanity checking: we check snapshot XTrees when they are taken, deleted -// and printed. We periodically check the main heap XTree with -// ms_expensive_sanity_check. -// +// Sanity checking: we check snapshot XTrees after they are taken, before +// they are deleted, and before they are printed. We also periodically +// check the main heap XTree with ms_expensive_sanity_check. static void sanity_check_XTree(XPt* xpt, XPt* parent) { Int i; @@ -670,19 +669,16 @@ // Check children counts look sane. tl_assert(xpt->n_children <= xpt->max_children); - // Check the sum of any children szBs equals the XPt's szB. + // Check the sum of any children szBs equals the XPt's szB. Check the + // children at the same time. if (xpt->n_children > 0) { SizeT children_sum_szB = 0; for (i = 0; i < xpt->n_children; i++) { + sanity_check_XTree(xpt->children[i], xpt); children_sum_szB += xpt->children[i]->curr_szB; } tl_assert(children_sum_szB == xpt->curr_szB); } - - // Check each child. - for (i = 0; i < xpt->n_children; i++) { - sanity_check_XTree(xpt->children[i], xpt); - } } ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Valgrind-developers mailing list Valgrind-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/valgrind-developers