Author: sewardj
Date: 2007-11-16 19:39:49 +0000 (Fri, 16 Nov 2007)
New Revision: 7167

Log:
Make one redirect mandatory for ppc64-linux.

Modified:
   trunk/coregrind/m_redir.c


Modified: trunk/coregrind/m_redir.c
===================================================================
--- trunk/coregrind/m_redir.c   2007-11-16 18:45:40 UTC (rev 7166)
+++ trunk/coregrind/m_redir.c   2007-11-16 19:39:49 UTC (rev 7167)
@@ -870,8 +870,10 @@
    /* If we're using memcheck, use these intercepts right from
       the start, otherwise ld.so makes a lot of noise. */
    if (0==VG_(strcmp)("Memcheck", VG_(details).name)) {
-      const HChar* croakage = "Possible fix: install glibc's debuginfo "
-                              "package on this machine.";
+
+      static HChar* croakage = "Possible fix: install glibc's debuginfo "
+                               "package on this machine.";
+
       /* this is mandatory - can't sanely continue without it */
       add_hardwired_spec(
          "ld.so.1", "strlen",
@@ -897,16 +899,21 @@
       the start, otherwise ld.so makes a lot of noise. */
    if (0==VG_(strcmp)("Memcheck", VG_(details).name)) {
 
+      static HChar* croakage = "Possible fix: install glibc's debuginfo "
+                               "package on this machine.";
+
+      /* this is mandatory - can't sanely continue without it */
       add_hardwired_spec(
          "ld64.so.1", "strlen",
          (Addr)VG_(fnptr_to_fnentry)( &VG_(ppc64_linux_REDIR_FOR_strlen) ),
-         NULL
+         croakage
       );
 
       add_hardwired_spec(
          "ld64.so.1", "index",
          (Addr)VG_(fnptr_to_fnentry)( &VG_(ppc64_linux_REDIR_FOR_strchr) ),
-         NULL
+         NULL /* not mandatory - so why bother at all? */
+         /* glibc-2.5 (FC6, ppc64) seems fine without it */
       );
 
    }


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Valgrind-developers mailing list
Valgrind-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/valgrind-developers

Reply via email to