On Sunday 09 December 2007 00:29, Ashley Pittman wrote: > On Sat, 2007-12-08 at 19:30 +0100, Julian Seward wrote: > > We can fix Memcheck by falling back to the reference version, but I'd > > like to see if there is a way to get the correct behaviour without > > the extra conditionals. > > Perhaps you could right shift the value before putting it into the tree?
The tree stuff is wrapped up in a general-purpose library (m_oset.c). What you say would indeed fix the problem for Memcheck's particular use of m_oset. But the problem potentially afflicts all users of m_oset.c, of which there are several. Also, Helgrind's hg_wordfm.c is a derivative of m_oset.c and contains the same problem and so also requires fixing. H leans heavily on the tree stuff - I think it builds 15 different trees for various purposes. J ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Valgrind-developers mailing list Valgrind-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/valgrind-developers
