On Tuesday 01 January 2008 18:11, Bart Van Assche wrote: > On Dec 30, 2007 1:30 PM, Tom Hughes <[EMAIL PROTECTED]> wrote: > > On 27/12/2007, Bart Van Assche <[EMAIL PROTECTED]> wrote: > > > The include file <pub_tool_libcproc.h> contains declarations for > > > various libc-functions. Two of these functions (VG_(getrlimit)() and > > > VG_(setrlimit)()) accept a pointer to a vki_rlimit structure. Inclusion > > > of pub_tool_vki.h is now required even when neither VG_(getrlimit)() or > > > VG_(setrlimit)() is called -- this is inconvenient. The attached patch > > > solves this. Can this patch please be committed on the trunk ? > > > > I'm not sure about this one - it looks like it rather violates the > > module boundaries. What do you think Julian?
There are various places where pub_tool_libc*.h requires pub_tool_vki.h included first. A minor inconvenience resulting from misusing struct vki_rlimit in the interface to m_libc* and as well as its original purpose of describing the hosts' syscall interface. I'd prefer to leave it as it is. A more serious module-related question for drd is that it should not include pub_core_*.h. Tools may only include pub_tool_*.h, in order to control the complexity of the core/tool interface. For one thing that will require adding the drd suppression file to DEFAULT_SUPP in configure.in - not a problem. Can you list precisely the stuff from the core_*.h includes that you need, that is not present in the tool_*.h files? J ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Valgrind-developers mailing list Valgrind-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/valgrind-developers
