On Tuesday 26 February 2008 20:36, Bart Van Assche wrote: > Hello Julian, > > The result of the regression test helgrind/tests/tc20_verifywrap > depends on the platform it is executed on (asserts with glibc 2.7 but > not with older glibc versions). Is it OK if I fix this by committing > the patch below ?
What is the effect on platforms < glibc 2.7? Does it cause the test to fail on those? J > > > Index: helgrind/tests/tc20_verifywrap.c > =================================================================== > --- helgrind/tests/tc20_verifywrap.c (revision 7483) > +++ helgrind/tests/tc20_verifywrap.c (working copy) > @@ -241,8 +241,8 @@ > memset(&s1, 0x55, sizeof(s1)); > r= sem_wait(&s1); /* assert(r != 0); */ > > - /* this really ought to fail, but it doesn't. */ > - r= sem_post(&s1); assert(!r); > + /* this only fails with glibc 2.7 or later. */ > + r= sem_post(&s1); > fprintf(stderr, "\nFIXME: can't figure out how to verify wrap of " > "sem_post\n\n"); > > > Bart. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Valgrind-developers mailing list Valgrind-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/valgrind-developers
