Author: sewardj
Date: 2008-03-03 15:51:58 +0000 (Mon, 03 Mar 2008)
New Revision: 7546

Log:
Don't be quite so paranoid about rejecting symbols that fall outside
the .text segment.  Instead only reject ones that fall outside the r-x
area.  This is in line with r7427, which instituted such a change in
other places in the system.



Modified:
   trunk/coregrind/m_debuginfo/readelf.c


Modified: trunk/coregrind/m_debuginfo/readelf.c
===================================================================
--- trunk/coregrind/m_debuginfo/readelf.c       2008-03-03 11:16:33 UTC (rev 
7545)
+++ trunk/coregrind/m_debuginfo/readelf.c       2008-03-03 15:51:58 UTC (rev 
7546)
@@ -458,7 +458,19 @@
 
 
    if (*is_text_out) {
-      if (!in_text) {
+      /* This used to reject any symbol falling outside the text
+         segment ("if (!in_text) ...").  Now it is relaxed slightly,
+         to reject only symbols which fall outside the area mapped
+         r-x.  This is in accordance with r7427.  See
+         "Comment_Regarding_Text_Range_Checks" in storage.c for
+         background. */
+      Bool in_rx;
+      vg_assert(di->have_rx_map);
+      in_rx = (!(*sym_avma_out + *sym_size_out <= di->rx_map_avma
+                 || *sym_avma_out >= di->rx_map_avma + di->rx_map_size));
+      if (in_text)
+         vg_assert(in_rx);
+      if (!in_rx) {
          TRACE_SYMTAB(
             "ignore -- %p .. %p outside .text svma range %p .. %p\n",
             *sym_avma_out, *sym_avma_out + *sym_size_out,


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Valgrind-developers mailing list
Valgrind-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/valgrind-developers

Reply via email to