On Fri, Jul 31, 2009 at 3:21 AM, Dan Kegel<[email protected]> wrote:
> I updated to trunk for the first time in a couple weeks, and started
> getting used to the changes.
>
> I had to switch to --xml-file instead of --log-file; the
> only fallout so far is that the command being executed is
> printed to stdout (or is it stderr):
> ==30291== Command: /home/dank/chromium/src/out/Debug/chrome ...
> which is kind of useless and annoying, especially on runs
> with lots of child processes.  If --xml is given, I'd suggest
> not printing the command to the normal log.

That was a bug, I've fixed it to not print that.

Julian and I were just discussing --xml=yes and its effect on the
normal text output channel.  I thought there were two obvious effects
to choose from:

1. Print everything on the text output channel as normal.  I.e.
--xml=yes doesn't affect it at all.

2. Print nothing on the text output channel.  But this is dangerous
because all diagnostics would be omitted, and it would make debugging
difficult.

However, in practice it does something in between those two extremes:

3. Print some of the usual stuff on the text output channel:  -d
output, -v output, the blank line at the start and end, maybe some
other stuff?.  Viz:

[wave:~/grind/ws2] vg-in-place --xml=yes --xml-file=/dev/null date
==83771==
Fri 31 Jul 2009 09:19:14 EST
==83771==

That's not what I expected.  (The User Manual talks about "residual"
text output, without defining what that includes.)  If we got rid of
those two blank (except for the PID) lines then it makes a certain
kind of sense... then --xml=yes turns off all the "user" output and
leaves behind only "debugging" output, ie. those lines begginning with
"--$PID--" instead of "==$PID==".

But I wonder if option (1) is better.  It would probably make the code
simpler, because we'd never have to decide whether to print something
as XML or normal text -- the XML would always be printed in addition.
(And that XML-or-normal-text logic does get tortured in some places.)

Anyway, Dan, as a user of the XML stuff do you have any preferences about this?

Nick

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Valgrind-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/valgrind-users

Reply via email to