On 09/01/2014 10:29 AM, Florian Krohm wrote:
This is a bug. I've openedhttps://bugs.kde.org/show_bug.cgi?id=338731
There is a patch attached to that bug that should fix the build issue.

Hi Florian,

I think there was an oversight in your patch file for ppc64 - I needed to remove '-maltivec'. My patch file is attached.

It would be good if you could try it out. And even better if you could
run this command

perl tests/vg_regtest none/tests/ppc64

To get it to run, I had to use the --valgrind option:

$ perl tests/vg_regtest --valgrind=/usr/bin/valgrind none/tests/ppc64

The results are provided below. I don't know valgrind, so I expect that I made a mistake somewhere along the line.

I'm curious about this tool / library, so I'm willing to spend some more time on it getting it working right for the e5500. I'll take another look at it this weekend.

Bob

-- Running  tests in none/tests/ppc64 ----------------------------------
jm-fp:           valgrind   ./jm-insns -f
*** jm-fp failed (stdout) ***
*** jm-fp failed (stderr) ***
jm-int:          valgrind   ./jm-insns -i
*** jm-int failed (stdout) ***
*** jm-int failed (stderr) ***
jm-misc:         valgrind   ./jm-insns -m
*** jm-misc failed (stdout) ***
*** jm-misc failed (stderr) ***
jm-vmx:          (skipping, prereq failed: ../../../tests/check_vmx_cap)
jm_fp_isa_2_07: (skipping, prereq failed: ../../../tests/check_isa-2_07_cap) jm_int_isa_2_07: (skipping, prereq failed: ../../../tests/check_isa-2_07_cap) jm_vec_isa_2_07: (skipping, prereq failed: ../../../tests/check_isa-2_07_cap)
lsw:             valgrind   ./lsw
*** lsw failed (stdout) ***
*** lsw failed (stderr) ***
power6_bcmp:     valgrind   ./power6_bcmp
*** power6_bcmp failed (stderr) ***
power6_mf_gpr:   valgrind   ./power6_mf_gpr
*** power6_mf_gpr failed (stdout) ***
*** power6_mf_gpr failed (stderr) ***
round:           valgrind   ./round
*** round failed (stdout) ***
*** round failed (stderr) ***
std_reg_imm:     valgrind   -q ./std_reg_imm
*** std_reg_imm failed (stdout) ***
*** std_reg_imm failed (stderr) ***
test_dfp1:       (skipping, prereq failed: ../../../tests/check_dfp_cap)
test_dfp2:       (skipping, prereq failed: ../../../tests/check_dfp_cap)
test_dfp3:       (skipping, prereq failed: ../../../tests/check_dfp_cap)
test_dfp4:       (skipping, prereq failed: ../../../tests/check_dfp_cap)
test_dfp5:       (skipping, prereq failed: ../../../tests/check_dfp_cap)
test_isa_2_06_part1: (skipping, prereq failed: ../../../tests/check_isa-2_06_cap) test_isa_2_06_part2: (skipping, prereq failed: ../../../tests/check_isa-2_06_cap) test_isa_2_06_part3: (skipping, prereq failed: ../../../tests/check_isa-2_06_cap) test_isa_2_07_part2: (skipping, prereq failed: ../../../tests/check_isa-2_07_cap) test_tm: (skipping, prereq failed: ../../../tests/check_isa-2_07_cap) test_touch_tm: (skipping, prereq failed: ../../../tests/check_isa-2_07_cap)
tw_td:           valgrind   ./tw_td
*** tw_td failed (stdout) ***
*** tw_td failed (stderr) ***
twi_tdi:         valgrind   ./twi_tdi
*** twi_tdi failed (stdout) ***
*** twi_tdi failed (stderr) ***
-- Finished tests in none/tests/ppc64 ----------------------------------

== 10 tests, 10 stderr failures, 9 stdout failures, 0 stderrB failures, 0 stdoutB failures, 0 post failures ==
none/tests/ppc64/jm-fp                   (stdout)
none/tests/ppc64/jm-fp                   (stderr)
none/tests/ppc64/jm-int                  (stdout)
none/tests/ppc64/jm-int                  (stderr)
none/tests/ppc64/jm-misc                 (stdout)
none/tests/ppc64/jm-misc                 (stderr)
none/tests/ppc64/lsw                     (stdout)
none/tests/ppc64/lsw                     (stderr)
none/tests/ppc64/power6_bcmp             (stderr)
none/tests/ppc64/power6_mf_gpr           (stdout)
none/tests/ppc64/power6_mf_gpr           (stderr)
none/tests/ppc64/round                   (stdout)
none/tests/ppc64/round                   (stderr)
none/tests/ppc64/std_reg_imm             (stdout)
none/tests/ppc64/std_reg_imm             (stderr)
none/tests/ppc64/tw_td                   (stdout)
none/tests/ppc64/tw_td                   (stderr)
none/tests/ppc64/twi_tdi                 (stdout)
none/tests/ppc64/twi_tdi                 (stderr)




afterwards.

    Florian


On 01.09.2014 06:35, Bob Cochran wrote:
Hello,

I was cross compiling valgrind tonight using OpenEmbbeded and ran into
an error during the compilation of none/tests/ppc64/jm-insns.c.

Although configure correctly determined that my Freescale T1040 (E5500)
doesn't support Altivec, the Makefile in none/tests/ppc64 appears to
have -maltivec hardcoded for jm_insns_CFLAGS.

Compiling failed when GCC was passed -maltivec.

I patched out the altivec flag in the Makefile, and my valgrind packages
finished building (won't try the test suite any time soon).

  From searching, I see that there have been Altivec issues in the past,
but I didn't see this particular issue come up.  Can I get some guidance
on whether this is a bug in the Makefile or whether it's something that
I should be avoiding if I had configured things differently?

Thanks

Bob







------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Valgrind-users mailing list
Valgrind-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/valgrind-users


>From 3cec7886b3991a6119bddb97c366842063f06126 Mon Sep 17 00:00:00 2001
From: Bob Cochran <openembed...@mindchasers.com>
Date: Fri, 5 Sep 2014 17:35:02 -0400
Subject: [PATCH] don't hard code maltivec flag

---
 none/tests/ppc64/Makefile.am |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/none/tests/ppc64/Makefile.am b/none/tests/ppc64/Makefile.am
index 93c6fe1..70d18be 100644
--- a/none/tests/ppc64/Makefile.am
+++ b/none/tests/ppc64/Makefile.am
@@ -48,8 +48,10 @@ AM_CCASFLAGS += @FLAG_M64@
 allexec_CFLAGS		= $(AM_CFLAGS) @FLAG_W_NO_NONNULL@
 
 if HAS_ALTIVEC
+BUILD_FLAG_ALTIVEC = -maltivec
 ALTIVEC_FLAG = -DHAS_ALTIVEC
 else
+BUILD_FLAG_ALTIVEC =
 ALTIVEC_FLAG =
 endif
 
@@ -86,8 +88,8 @@ test_isa_2_06_part2_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames $(VSX_
 test_isa_2_06_part3_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -lm -g -mregnames $(VSX_FLAG) \
 			@FLAG_M64@ $(ALTIVEC_FLAG) $(BUILD_FLAG_VSX)
 
-jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames -maltivec \
-			@FLAG_M64@ $(ALTIVEC_FLAG)
+jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames \
+			@FLAG_M64@ $(ALTIVEC_FLAG) $(BUILD_FLAG_ALTIVEC)
 
 test_dfp1_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -lm -g -mregnames $(DFP_FLAG) \
 			@FLAG_M64@ $(BUILD_FLAGS_DFP)
-- 
1.7.9.5


------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Valgrind-users mailing list
Valgrind-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/valgrind-users

Reply via email to