Hi Eyal, On Fri, 2023-10-27 at 21:44 -0600, Eyal Soha wrote: > I have uploaded two possible fixes but I'm unable to test them. If someone > is able to reproduce this bug faithfully, can you try each patch below and > let me know if it works? You can apply the patch with `git am <filename>'. > > Download these: > > https://bugs.kde.org/attachment.cgi?id=162607 (I prefer this one.) > https://bugs.kde.org/attachment.cgi?id=162608 (If that one doesn't work, > maybe this one?)
Very nice analysis. I put some comments in the bug, but in general I think you found (and fixed) the issue. > To test, you can run this: > > ./autogen.sh && ./configure && make -j 20 && make -j 20 check && valgrind -q > --expensive-definedness-checks=yes memcheck/tests/vbit-test/vbit-test vbit-test for s390x needs to run from the actual memcheck/tests/vbit- test (see the source, there is a system call to S390X_FEATURES in it). But if you run it (with you patch) it works as intended: $ ../../../vg-in-place --expensive-definedness-checks=yes ./vbit-test ==2242090== Memcheck, a memory error detector ==2242090== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al. ==2242090== Using Valgrind-3.22.0.RC2 and LibVEX; rerun with -h for copyright info ==2242090== Command: ./vbit-test ==2242090== ==2242090== ==2242090== HEAP SUMMARY: ==2242090== in use at exit: 0 bytes in 0 blocks ==2242090== total heap usage: 256 allocs, 256 frees, 104,448 bytes allocated ==2242090== ==2242090== All heap blocks were freed -- no leaks are possible ==2242090== ==2242090== For lists of detected and suppressed errors, rerun with: -s ==2242090== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0) and even with the system valgrind: $ valgrind --expensive-definedness-checks=yes ./vbit-test ==2242137== Memcheck, a memory error detector ==2242137== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al. ==2242137== Using Valgrind-3.21.0 and LibVEX; rerun with -h for copyright info ==2242137== Command: ./vbit-test ==2242137== ==2242137== ==2242137== HEAP SUMMARY: ==2242137== in use at exit: 0 bytes in 0 blocks ==2242137== total heap usage: 256 allocs, 256 frees, 104,448 bytes allocated ==2242137== ==2242137== All heap blocks were freed -- no leaks are possible ==2242137== ==2242137== For lists of detected and suppressed errors, rerun with: -s ==2242137== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0) Thanks, Mark _______________________________________________ Valgrind-users mailing list Valgrind-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/valgrind-users
