On Thu, 28 Aug 2025 16:37:22 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor diff
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 1423:
>
>> 1421: if (sym.name == names._this || sym.name ==
>> names._super) {
>> 1422: // are we seeing something like `this` or
>> `CurrentClass.this` or `SuperClass.super::foo`?
>> 1423: if (TreeInfo.isExplicitThisReference(
>
> Do we always report an error when seeing `Foo.this` ? What if we're not
> inside the prologue of `Foo` ?
all the code we analyze in this visitor is in the prologue, this is why we
pre-select what code we will see
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1523#discussion_r2308100999
