On Wed, 3 Sep 2025 02:39:19 GMT, Chen Liang <[email protected]> wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Forgot a TODO
>
> src/hotspot/share/cds/archiveBuilder.cpp line 827:
>
>> 825: num_obj_array_klasses ++;
>> 826: type = "ref array";
>> 827: } else if (k->is_objArray_klass()) {
>
> Is this redundant? I think flat arrays union ref arrays = obj arrays?
The VM creates instances of `ObjArrayKlass` that are not instances of
`RefArrayKlass` nor `FlatArrayKlass`.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1452#discussion_r2319260824