On Wed, 17 Sep 2025 13:40:44 GMT, Maurizio Cimadamore <[email protected]> wrote:
>> Although, it might be tricky to see whether the warning is enabled or not >> here. The new design is to issue all warnings all the time, on the basis >> that typically it's too early to filter here, (but, you don't yet have the >> latest javac changes here) > > At the very least, we can just not do the scan if `addedSuperInIdentityClass` > but `!allowValueClass` -- so that w/o Valhalla enable, there's no weird > regression. scratch that -- you need the check always. I just don't get the `allowValueClass` filter here, but I guess we want to make the warnings conditional on --enable-preview, which is ok ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1595#discussion_r2355602582
