On Wed, 17 Sep 2025 13:09:42 GMT, Frederic Parain <[email protected]> wrote:
>> This change adds comments for LoadableDescriptors for inline field layout >> processing to the class loading comments. The other changes are to make the >> valhalla version of placeholders and systemDictionary match what is in >> mainline. In mainline, interface and super class calls >> resolve_super_or_fail, otherwise we call resolve_with_circularity_detection. >> There are some other comments in mainline in these files that aren't great, >> that are not addressed here in the Valhalla version. >> Tested with tier1 locally. > > src/hotspot/share/classfile/systemDictionary.cpp line 479: > >> 477: MutexLocker mu(THREAD, SystemDictionary_lock); >> 478: >> 479: // Must check ClassCircularity before resolving next_name >> (superclass, interface or LoadableDescriptor class). > > Could we say "superclass, interface or field type" in order to cover both the > loads triggered by the LoadableDescriptors attribute and the loads triggered > by the null-restriction annotation? > It applies to the comment at line 503 too. "field type" is not sufficient either, because the LoadableDescriptors attribute is also used to speculative pre-load argument types. Any thought on a better name ? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1594#discussion_r2355562467
