On Mon, 22 Sep 2025 18:08:16 GMT, Coleen Phillimore <[email protected]> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   remove frames_size parameter and code duplication from 
>> remove_scalarized_frames
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 2076:
> 
>> 2074: 
>> 2075: int 
>> ThawBase::remove_scalarized_frames(StackChunkFrameStream<ChunkFrames::CompiledOnly>&
>>  f, stackChunkOop chunk, int &argsize) {
>> 2076:   DEBUG_ONLY(intptr_t* const chunk_sp = chunk->start_address() + 
>> chunk->sp();)
> 
> Can you remove the 'chunk' parameter too?

Right, also not needed. Removed.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/1603#discussion_r2369765073

Reply via email to