On Tue, 30 Sep 2025 19:29:03 GMT, Frederic Parain <[email protected]> wrote:
> Create new method entry for the interpreter to add a memory barrier when
> entering the j.l.Object constructor.
Apart from the request for comments on the unchanged ports so we know the
barrier isn't needed and is deliberately skipped, this looks great!
Thanks Fred
src/hotspot/cpu/arm/templateInterpreterGenerator_arm.cpp line 1:
> 1: /*
Can you add a comment mentioning StoreStore at the equivalent place in this
method? It'll make it easier to find where the barrier is expected / compare
across platforms. I always trip on the fact that the x86 `_return`
implementation doesn't mention anything
src/hotspot/cpu/arm/templateInterpreterGenerator_arm.cpp line 1142:
> 1140: // Generic interpreted method entry to (asm) interpreter
> 1141: //
> 1142: address TemplateInterpreterGenerator::generate_normal_entry(bool
> synchronized, bool object_init) {
Same request about a comment here
src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp line 1242:
> 1240: // Generic interpreted method entry to (asm) interpreter
> 1241: //
> 1242: address TemplateInterpreterGenerator::generate_normal_entry(bool
> synchronized, bool object_init) {
Same request for a comment so there's breadcrumbs to find
-------------
Marked as reviewed by heidinga (no project role).
PR Review:
https://git.openjdk.org/valhalla/pull/1647#pullrequestreview-3286462141
PR Review:
https://git.openjdk.org/valhalla/pull/1647#pullrequestreview-3289427747
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1647#discussion_r2392648397
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1647#discussion_r2392648933
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1647#discussion_r2392650179
