On Wed, 1 Oct 2025 20:51:25 GMT, Chen Liang <[email protected]> wrote:
>> Vicente Romero has updated the pull request incrementally with one >> additional commit since the last revision: >> >> do not generate proxy variables for warned code > > test/lib/jdk/test/lib/NetworkConfiguration.java line 1: > >> 1: /* > > We should probably ignore initialization warnings for test libs at: > https://github.com/openjdk/valhalla/blob/2bc50b323a5c57f5d55094196729f54b7dd98302/make/test/BuildTestLib.gmk#L65 yes we could, but I prefer not to. I found bugs in the original implementation by analyzing case by case the reason for the warnings. If we remove it for all tests then we could be blinded to lwrking bugs ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1650#discussion_r2398992215
