On Fri, 3 Oct 2025 14:24:08 GMT, Coleen Phillimore <[email protected]> wrote:
>> src/hotspot/share/oops/oop.inline.hpp line 100: >> >>> 98: // This is for parallel gc, which doesn't always have the klass. >>> 99: // markWord::must_be_preserved preserves the original prototype header >>> bits for EnableValhalla, >>> 100: // I don't know why serial gc doesn't work the same. >> >> We should probably find out why. I can ask around. > > Thank you! That would be good. The prototype_mark() function above or even > init_mark shouldn't have to be conditional on EnableValhalla if the markWord > is always preserved. But serial gc is very unhappy with that. To be clear I think this should be a further investigation because this should fix a lot of ParallelGC tests that are currently failing. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1655#discussion_r2402885968
