On Sat, 4 Oct 2025 04:09:14 GMT, Chen Liang <[email protected]> wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> addressing review comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 1490:
>
>> 1488: if (mode !=
>> PrologueVisitorMode.WARNINGS_ONLY) {
>> 1489: if (mode ==
>> PrologueVisitorMode.THIS_CONSTRUCTOR) {
>> 1490: reportPrologueError(tree, sym);
>
> Can merge this with the `else` in the `allowValueClasses` check above for
> simplicity.
I refactored the code
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1659#discussion_r2404664945
