On Thu, 2 Oct 2025 08:26:56 GMT, Paul Hübner <[email protected]> wrote:
>> Hi all, >> >> This PR refactors the mark word to use the order of bits as specified in >> [JEP 450](https://openjdk.org/jeps/450). >> >> Specifically, there are three portions to this change: >> - Moving the age bits lower to their intended position. >> - Fixing a miscompilation in the native `hashCode` intrinsic that got >> unearthed as a result. >> - Updating the documentation to be more inline with the mainline docs and >> minimal Valhalla additions. >> >> Feedback is welcome, especially for the doc changes. If there are any ideas >> of other places in which similar miscompilations could occur, that would be >> valuable to know as well. > > Paul Hübner has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains nine additional > commits since the last revision: > > - Remove unused prototype method. > - Merge branch 'lworld' into JDK-8367073 > - Revise documentation. > - Fix hashCode intrinsic miscompilation. > - Fix outdated markWord test semantics. > - Chuck out weird markWord code. > - Emulate old Valhalla decode_pointer behavior. > - Fix typo. > - Follow JEP450 MarkWord specification. Hi all, I've merged in `84c7c0a2bf8e05d791058acb18f3d0f7032dabbd` and re-run all the tests. I saw no new failures or failures that could not be attributed to known issues. I would like re-approval to proceed with integration. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1578#issuecomment-3396606265
