On Tue, 21 Oct 2025 06:49:52 GMT, Christian Hagedorn <[email protected]> 
wrote:

> When adding packages in 
> [JDK-8369437](https://bugs.openjdk.org/browse/JDK-8369437), some compile 
> commands were not updated accordingly as well. This is fixes with this patch.
> 
> Thanks,
> Christian

test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestOopsInReturnConvention.java
 line 33:

> 31:  * @run main/othervm/timeout=300 -Xbootclasspath/a:. 
> -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI
> 32:  *                               -Xbatch -XX:-TieredCompilation
> 33:  *                               
> -XX:CompileCommand=dontinline,*TestOopsInReturnConvention*::callee

I think the `*` after `TestOopsInReturnConvention` was missing before: 
`callee()` is only defined in the inner class `LargeValueWithOops`.

test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestUnloadedInlineTypeArray.java
 line 48:

> 46:  * @run main/othervm -Xcomp -XX:-UseArrayFlattening
> 47:  *                   
> -XX:CompileCommand=compileonly,*TestUnloadedInlineTypeArray::test*
> 48:  *                   
> compiler.valhalla.inlinetypes.TestUnloadedInlineTypeArray

Added missing package - forgot to do in JDK-8369437.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/1689#discussion_r2446897190
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/1689#discussion_r2446898093

Reply via email to