On Tue, 28 Oct 2025 10:41:52 GMT, Damon Fenacci <[email protected]> wrote:
> # Issue > > Several Valhalla compiler specific tests are slow and this affects the > overall execution time of lower tiers. > [JDK-8369437](https://bugs.openjdk.org/browse/JDK-8369437) has already > improved the situation by splitting multiple @run statements in compiler > tests into separate @test blocks for several tests. There are nevertheless > still a handful of tests that take up to a dozen minutes to finish. > > # Cause > > Most tests affected are using multiple IR-Framework scenarios to start tests > with different flags. The tests are started sequentially, adding the > execution time of each test. The problem is similar to > [JDK-8369437](https://bugs.openjdk.org/browse/JDK-8369437) but at > IR-Framework level. > > # Fix > > We can parallelize the execution of scenarios similar to what has been done > in the [fix](https://github.com/openjdk/valhalla/pull/1681/files) for > [JDK-8369437](https://bugs.openjdk.org/browse/JDK-8369437). Unfortunately the > IR-Framework doesn't allow tests to be run on different machines and there is > no simple way to make it interact with JTReg in that way. So, as a > provisional and minimalistic solution, scenarios are added and started one by > one and run by individual JTReg `@test` entries. > > # Testing > > Tier 1-3 > Worst-time compiler/valhalla JTReg tests went from 16min to <2min Thank you for this vast improvement, @dafedafe! This looks good to me, bar the superfluous import. test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestCallingConvention.java line 34: > 32: import java.lang.invoke.MethodType; > 33: import java.lang.reflect.Method; > 34: import java.util.Arrays; Suggestion: I don't see why this is being added. ------------- Marked as reviewed by mhaessig (no project role). PR Review: https://git.openjdk.org/valhalla/pull/1708#pullrequestreview-3389200955 PR Review Comment: https://git.openjdk.org/valhalla/pull/1708#discussion_r2469879564
