On Wed, 5 Nov 2025 21:50:58 GMT, Alex Menkov <[email protected]> wrote:
>> The fix re-implements flat object support in heap dumper. >> New approach does not require changes in .hprof format. >> Flat value objects are dumped as heap-allocated objects with generated ID. >> For heap-allocated objects the ID is their address (oop), they are always >> aligned. >> ID generator for flat objects uses unaligned values (so there is no >> conflicts with oops). >> >> HeapDump test was reimplemented (it was disabled for a long time) >> Changes in hprof test lib were reverted (they are not needed anymore) >> >> testing: tier1..4,hs-tier5-svc > > Alex Menkov has updated the pull request incrementally with one additional > commit since the last revision: > > removed T_FLAT_ELEMENT in StackRefDumper Not a heap dump expert, but the handling of flat fields and flat arrays in the heapDumper code look good to me. ------------- Marked as reviewed by fparain (Committer). PR Review: https://git.openjdk.org/valhalla/pull/1700#pullrequestreview-3430318341
