On Thu, 6 Nov 2025 22:24:29 GMT, Roger Riggs <[email protected]> wrote:
>> David Beaumont has refreshed the contents of this pull request, and previous
>> commits have been removed. Incremental views are not available.
>
> src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java line
> 365:
>
>> 363: if (name.startsWith("/modules/") ||
>> name.startsWith("/packages/")) {
>> 364: throw new IllegalArgumentException("Invalid entry
>> name: " + name);
>> 365: }
>
> This can be covered by the == null case below. The distinguished exception
> isn't necessary.
Note that these changes were only temporary in this PR as a way to let people
see where this was going.
They're being reverted and this PR reset to the
I wasn't expecting anyone to try and review it. Sorry.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1719#discussion_r2503601081
