On Fri, 21 Nov 2025 15:52:48 GMT, Paul Hübner <[email protected]> wrote:
>> Hi all, >> >> This patch fixes several `int` overflows relating to flat array element >> loads/stores. >> I've included some gtests that address a subset of these changes. We should >> test flat arrays larger than 16GB in size, which is not something we can >> feasibly do in our tier1 jtreg tests. I've filed >> [JDK-8372261](https://bugs.openjdk.org/browse/JDK-8372261) as a follow-up >> RFE to investigate this. >> >> Testing: tiers 1-4, >> [`LocalityCheck.java`](https://bugs.openjdk.org/secure/attachment/117136/LocalityCheck.java) >> run locally 100 times. > > Paul Hübner has updated the pull request incrementally with one additional > commit since the last revision: > > C1 changes I added a regression test, it doesn't actually take very long to run (I was mostly running slowdebug so I was under the impression it was much slower than it actually is) and the memory could be constrained by jtreg. Convenient. I still think that even with this test, [JDK-8372261](https://bugs.openjdk.org/browse/JDK-8372261) applies and should be investigated further. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1752#issuecomment-3563887185
