On Fri, 28 Nov 2025 14:11:51 GMT, Manuel Hässig <[email protected]> wrote:
>> Marc Chevalier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5912:
>
>> 5910: if (framesize < ((1 << 9) + 2 * wordSize)) {
>> 5911: sub(sp, sp, framesize);
>> 5912: if (DEBUG_ONLY(zap_rfp_lr_spills) NOT_DEBUG(false)) {
>
> Suggestion:
>
> if (DEBUG_ONLY(zap_rfp_lr_spills ||) false) {
>
> This would be an alternative, if you want to reduce macro noise.
Yep, thought about that too. I like it equally.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1764#discussion_r2571813474
