On Tue, 2 Dec 2025 09:15:22 GMT, Paul Hübner <[email protected]> wrote:
>> PreviewFeatures.isEnabled() is internal and not accessible without adding >> some `@module` in each IR test. That seems like an excessive burden. >> >> Doing it more fine-grained was on purpose. @TobiHartmann an opinion? I tihnk >> it can make a mess with other project repos, but I don't remember the exact >> scenario. > > Right, adding it to every test doesn't feel like the way to go! I'm not too > fussed about it, it was just a suggestion, feel free to disregard ;) I think it might not be doable indeed. There is still the question of `"enable-valhalla", "true"` or `"enable-preview", "true"`. While the first version was to do an `enable-preview` (up to the difficulties of testing it...), after discussion with @TobiHartmann, `enable-valhalla` had upsides, which I fear I don't remember. If we change the name to `enable-preview`, the way we check it might be... confusing, but fine for now. Also, the current solution makes it easier to update tests in the future when Valhalla won't be preview anymore. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1767#discussion_r2580328491
