On Thu, 4 Dec 2025 22:38:39 GMT, Roger Riggs <[email protected]> wrote:
>> This test failing with VM options prompted a refatoring and cleanup of the >> test (and renaming to be more appropriate). >> The test is re-enabled with a 4 combinations of command line flags. >> >> Refactored test to verify that hashcode changed with each change to a field. >> Previously, the test tried to compute the hashCode for the value class. That >> was fragile in the presence of the VM changing the layout information. Check >> the hashCodes are equal for objects that are `.equals`. Renamed to >> 'ValueObjectMethodsTest`. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Correct check for identityHashCode Marked as reviewed by liach (Committer). ------------- PR Review: https://git.openjdk.org/valhalla/pull/1771#pullrequestreview-3542463959
