Re: [lworld] RFR: 8373442: [lworld] Fix CDS heap dumping crashes

[Ioi Lam]

On Wed, 10 Dec 2025 17:23:06 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:

> This fixes three crashes in when heap dumping is enabled with Matias's patch.
> Tested with tier1-3, that doesn't exactly turn on valhalla and some 
> --enable-valhalla testing locally.

src/hotspot/share/cds/aotStreamedHeapWriter.cpp line 393:

> 391:   narrowKlass nk = 
> ArchiveBuilder::current()->get_requested_narrow_klass(src_klass);
> 392: 
> 393:   markWord mw = Arguments::enable_preview() ? 
> src_klass->prototype_header() : markWord::prototype();

Why is `Arguments::enable_preview()` check necessary here but not in 
aotMappedHeapWriter.cpp‎?

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/1784#discussion_r2607657822